HeliCAS - a helicopter collision avoidance script (ACCEPTED)

[Mr.Peanut]

I've got a script that helps keep AI helicopters from flying into each other, a common and frustrating occurrence. Download the demo below and watch the helicopters try to avoid each other.  I have two issues with which I need help. Well, I have many issues that need helping but that is between me and my psychiatrist.  

1)I have the following code line in the main script:

Code: [Select]

If ((([_newpos Select _i, _newpos Select _j] Call Distance3D) < _dist) And (Alive ( _heli Select _i)) And (Alive (_heli Select _j))) Then {[(_heli Select _i),(_heli Select _j),(_newpos Select _i),(_newpos Select _j),(_hvel Select _i),(_hvel Select _j),(_hlist Select _i),(_hlist Select _j),_spd,_dt] Exec "avoid.sqs"}  
Even though I detect whether the two helicopters are alive, sometimes this causes an error if a helicopter dies just as this code line is being executed. It doesn't cause any problems in the script, but I would like to get rid of the unsightly error message.

2) Since this script is for only meant for AI helicopters, I think it could work in MP if run only on the server, but I am not certain. Any thoughts on this would be welcome.


Get HeliCAS v1.1

[Fragorl]

What was the error message?

[Mr.Peanut]

I can't read the %^#%&^ error message because it gets cut off.
sigh... to reproduce the error use these settings in the demo.

_dist = 10
_spd = 1
_dt = 1
_delay = 0.1

[SEAL84]

Eh, I fired this up....and they all plowed into each other and exploded.

Tried again and nobody went down, but they were constantly bumping into each other.  They don't seem to start avoiding until they're literally about to smash into another chopper, and if they're going too fast, they're just going to collide anyway.

Is there a way to make them give each other wider margins?  Even if they don't go down, seeing two choppers get into a fender-bender is still bad.

[Homefry31464]

As for the error, perhaps it is because you are starting with '((([' and ending with ']'?  If you can follow what I mean, perhaps the brackets are wrong..?

[Mr.Peanut]

That's strange. On my machine they rarely collide with the settings provided in the demo, though sometimes they take 10-20 seconds to sort themselves out.  Having 8 helicopters colliding at once was just to show that they don't all die every time.  Remove the helicas line from the init.sqs and then watch what happens.

Try increasing the avoidance speed and distance i.e. _spd and _dist. It's not a perfect script but it is not load heavy and does help prevent helicopters from colliding.

Eh, I fired this up....and they all plowed into each other and exploded.

Tried again and nobody went down, but they were constantly bumping into each other.  They don't seem to start avoiding until they're literally about to smash into another chopper, and if they're going too fast, they're just going to collide anyway.

Is there a way to make them give each other wider margins?  Even if they don't go down, seeing two choppers get into a fender-bender is still bad.

[Fragorl]

PROBLEM SOLVED ! I think ...

In helicas you have the line :

Code: [Select]

#testalive
    If Not(Alive (_heli Select _i)) Then {_tmpheli = _tmpheli - [_heli Select _i]; _tmphlist = _tmphlist - [_hlist Select _i]}

The problem is _tmphlist = _tmphlist - [_hlist Select _i]}
. Reason: upon examination, all members of '_tmphlist' are the same: something like ["_i","_i","_i" ...] and so on. The error occurs whenever one of the helicopters dies.
When you subtract [_hlist select _i] from _tmphlist, ofp removes All the elments, as they are all the same.

Therefore, you end up with

Code: [Select]

... (_hlist Select _i) ... |#| Error Zero Divisor, as for this particular loop of "heli2" your _hlist is empty, []. (Doing a hint format ["%1",(_hlist Select _i) ]) confirms it is this that is causing the error zero divisor message

The _hlist is regenerated after the next #mainloop so you don't get repeated error messages.

Solution: Replace the code after #testalive with this code:

Code: [Select]

#testalive
_hlist = []
    If Not(Alive (_heli Select _i)) Then {_tmpheli = _tmpheli - [_heli Select _i]}
    _i = _i + 1
If (_i < _n) Then {Goto "testalive"}
_heli = +_tmpheli
"_hlist = _hlist + [""_i""] " foreach _heli
_hlist = +_tmphlist
_tmpheli = NIL
_n = Count _heli
;Don't need  a CAS for only 1 helicopter
If (_n < 2) Then {Exit}
Hope that solves the problem.

[Mr.Peanut]

Well, I found one bug thanks to your comment.
I had a line that read:

Code: [Select]

{_hlist Set [_i, Format["_i"]]; _i = _i + 1 } ForEach _heli
but it should be:

Code: [Select]

{_hlist Set [_i, Format["%1",_i]]; _i = _i + 1 } ForEach _heli
This list is used in generating names for boolean variables that  allow only one entry into avoid.sqs for a colliding pair of helicopters.

I have updated code download above...

How did you manage to see the whole error message?

[Fragorl]

I saw that the error message was coming from that long line starting with 'if...' after #heli2
I guessed it was a zero divisor error, coz that happens to me alot, so i commented out the if... line and replaced it with
"hint format ["%1",[_hlist select _i]]" (actually i tried that probably last)
then it came up with  the hint format line + the error message which i could read.

Also i checked _hlist with a hint format, thats how i could see it was empty []. Did replacing that section of code work?

[Mr.Peanut]

I didn't replace the section of code because it didn't seem necessary after I made the correction indicated in my last post.

[Fragorl]

Ah, I see, _hlist = [0,1,2,3,4...] not ["_i","_i","_i" ...]. So you can remove nmbers individually without cleaning out the whole array

[Mr.Peanut]

_hlist = ["0","1","2","3","4",...]

[Big Nasty]

How is this script coming along? It sounds very useful.

[Mr.Peanut]

Script works and is fully debugged.  I've tested it for use in a mission I'm making in which the player is pursued by 6 helicopters.  The helicopters rarely crash into each other.  I didn't bother doing any more work or docs on it due to the lack of a positive response, and I am not sure how to get it to work in multiplayer.  I suspect if it is run only on the server it may work in multiplayer, but without expert advice on SetVelocity, I can not make any guarantees.

I have updated the demo download with a small change and also submitted to ofpec.

[Fragorl]

Prolly a bit too late for this, but seeming as the thread has been revived, I have a couple of ideas for making the script itself more user-friendly.

1.) The calling bit requires lots of numbers that the user has to look up in the readme. Perhaps give them some 'default' values (the ones that u find work best) and so allow them the opportunity to put nothing in. So, from the main script:

Code: [Select]

;  I have found the following values to work best.
;  _dist = 10
;  _spd = 2
;  _dt = 1
;  _delay = 0.05

_heli = _this Select 0
_dist = _this Select 1
_spd = _this Select 2
_dt = _this Select 3  
_delay = _this Select 4  

?format["%1",_dist] == "scalar bool array string 0xfcffffef":_dist = 10
?format["%1",_spd] == "scalar bool array string 0xfcffffef":_spd = 2
?format["%1",_dt] == "scalar bool array string 0xfcffffef":_dt = 1
?format["%1",_delay] == "scalar bool array string 0xfcffffef":_delay = 0.05
2.) Instead of requiring the user to basically give you an array of all the choppers in the game, perhaps allow them to just use the choppers they want helicas for. Then run a looping 'nearestobject' command and check for tyoe using "air" counttype [_nearestobj] ==1 to find if it should do a helicas or not.

Regardless, I thought it was a very cool script, and I often use it out of sheer frustration when im dealing with more than about 2 choppers. shoopid ai.


EDIT: i can never remeber when to use "scalar etc etc etc" and when to use "<null>". Tis one of the two