Rank function - Help needed

[h-]

Well, after a relentless testing (amongst the whirlwind of MCAR developement) I've managed to dig up a way of determining the rank given for a unit in the mission editor. So, this function would most probably be called getRank then ...

Now, you may ask yourselves what's the use for this function..
I asked it myself and found no pleasing answer really ;D...
Other than some AI scripts and/or CoC AI on Demand style deleteVehicle/re-createVehicle scripts...

Anyway, I've almost cracked up this thing, but the problem seems to be the vehicles...
In OFP, the rank given to any vehicle is given to the vehicles driver, the next higher rank is given to the gunner, and the next higher to the commander...
Now, obviously, the getRank should then return the drivers rank, but it seems that what ever I do the wrong rank is returned, usually one higher than the drivers actual rank or just PRIVATE or that really annoying 'scalar puiwpiopwueru' error...
For some reason I just can' get this stuff sorted, and as you see, there's a way in the code (one out of many) I've tried to use but with no luck...

So what he function would now need is a way of detecting whether the passed unit is a vehicle and if so, then 'treating' all the crew and cargo inside it so that the rank can be attained from then if they for example exit the vehicle... Which the cargo will most likely do at some point...

I've attached the function to this post...
I also quote the code below...

Read carefully the usage instructions from the .sqf itself (the attached file outdated, don't use...) before using, it's a bit tricky... (and too long to quote here...)

Code: [Select]

private ["_all","_unit","_task","_mkunit","_mk_ratU","_mkratUx","_rank","_ratU","_ratUx","_ratUm"];
_all    = _this select 0;
_unit   = vehicle (_this select 1);
_task   = _this select 2;

if (_task != "mark_htr" && _task != "rank_htr")
 then
    {
     hint format ["ERROR!!\nTask -> %1 <- not regocnised!\nUse only 'mark_htr' or 'rank_htr'.",_task];
     _rank = "<null>";
    };

if (_task == "mark_htr")
 then
    {
     _cnt      = count _all;
     _mkratU   = 0;
     _mkratUx  = 0;
     _i        = 0;

     while "_i <= _cnt"
       do
        {
     _mkunit = _all select _i;
     if ("Man" countType [_mkunit] < 1)
          then
         {
      _mkunit = (driver _mkunit);
         };
         _mkratUx = rating _mkunit;

     _mkunit addRating _mkratUx - (_mkratUx * 2);
         _mkratU = _mkratUx / 10000;
     _mkunit addRating (_mkratUx + (_mkratU / 2)) + 10;

     _i = _i + 1;
      };
  };


if (_unit in _all && alive _unit)
 then
    {
      _ratUx = rating _unit;
   if ("Man" countType [_unit] < 1)
        then
       {
        _ratUx = rating (driver _unit);
       };
   if (_ratUx < 0 && _ratUx > -2000)
        then
       {
        _ratUx = abs _ratUx;
       };
      _ratUm = _ratUx - (_ratUx mod 1);
      _ratU = ((_ratUx - _ratUm) * 10000) + random 3;
      _ratU = _ratU * 2;

   if (_ratU >= 7500)
    then {_rank = "COLONEL";};

   if (_ratU >= 5000 && _ratU < 7500)
    then {_rank = "MAJOR";};

   if (_ratU >= 3500 && _ratU < 5000)
    then {_rank = "CAPTAIN";};

   if (_ratU >= 2500 && _ratU < 3500)
    then {_rank = "LIEUTNANT";};

   if (_ratU >= 1500 && _ratU < 2500)
    then {_rank = "SERGEANT";};

   if (_ratU >= 500 && _ratU < 1500)
    then {_rank = "CORPORAL";};

   if ((_ratU >= 0 && _ratU < 500))
    then {_rank = "PRIVATE";};
    }
   else
      {
   if ((rating _unit) > -2000 && alive _unit)
    then
       {
        hint format ["ERROR!!\n%1 not in the given array!",_unit];
        _rank = "<null>";
       };
   if ((rating _unit) <= -2000 && alive _unit)
    then {_rank = "RENEGADE TREASENOUS BASTARD!!!!";};
      };

_rank

And I sure hope General Barron doesn't show up saying 'oh, I did this too already' ;D ;D

[sim]

wow, looks quite.... complicated, lol.  

I'll have to give it a try.

And I sure hope General Barron doesn't show up saying 'oh, I did this too already'

He probably will, he always does  

sim

[General Barron]

[shadow=red,left,300]I DID THIS TOO ALREADY!!![/shadow]  

[/size][/font][/color]

Lol... just kidding. Nah, I knew you could find the unit's rank at the start of a mission by looking at its rating, but the idea of "storing" that rank in the unit's rating is very clever indeed.

Now, I haven't looked at the code too in depth yet, and I haven't tried it in game, but I get the general idea of it. First off, these parts confuse me:

Code: [Select]

    _mkunit addRating _mkratUx - (_mkratUx * 2);
         _mkratU = _mkratUx / 10000;
     _mkunit addRating (_mkratUx + (_mkratU / 2)) + 10;
... .... .. .. . ... ..
      _ratUm = _ratUx - (_ratUx mod 1);
      _ratU = ((_ratUx - _ratUm) * 10000) + random 3;
      _ratU = _ratU * 2;Is that the "crappy/weird 'maths like' " stuff you are talking about? I understand the first line, but the next two are.... very, very strange, unless I just don't get it. Well, you say that OFP does some weird stuff with long decimal numbers. This could be because of the way floating point numbers work on a binary level: they are limited to a fixed number of digits. So the more digits in front of the decimal, the less digits can be behind the decimal, and the computer has to round. So maybe when the unit gains more score, then things start getting screwed up.

Just a possibility, I guess. But perhaps it would help to do this:
   Private -> rating + 0.1
   Corporal -> rating + 0.2
   Sergeant -> rating + 0.3
And so on and so forth.  That way there are less numbers after the decimal to get messed up with OFP's 'fuzzy math'.


As for your problem with vehicles, I don't have a very good answer. All I know is I don't really understand how vehicles work in scripts, when it isn't an empty vehicle that had units moved into it. That's why I never even place manned vehicles anymore (just an empty one and then moveindriver someone) :crazy:. But I have some thoughts.... basically, you shouldn't use the "driver" command for vehicles, because some vehicles have no driver (eg, m2 machine guns). I think the "crew" command would be better (returns an array of everybody in the vehicle). That way you can 'mark' everybody in the vehicle, and also 'read' everybody in the vehicle.


Okay, a few more comments on the script. First off, it appears to do the "rank" routine even when you call the script for the "mark" routine. That's just a waste of resources, which could be a big drain at the start of the map with lots of units.
Also, why on earth should it be called with the "nil" in the middle of the parameters? Why not make the unit (where the nil goes) the very last parameter, and then only check that parameter when you are doing the "rank" routine. You could also get rid of the whole "rank_htr"/"mark_htr" string: just make it do the "rank" routine if a unit has been passed, otherwise it does the "mark" routine. For example:

[array, <unit>] call getRank

_array = _this select 0
if (count _this > 1) then {_unit = _this select 1; do rank routine}
else {do mark routine}

[h-]

Is that the "crappy/weird 'maths like' " stuff you are talking about? I understand the first line, but the next two are....

;D
Actually, even I can't remember why I had to do it like that..
_mkunit addRating _mkratUx - (_mkratUx * 2); -> changes the units rating to 0
_mkratU = _mkratUx / 10000; -> original rating 'taken' from the unit is put below the decimal, so it's now 0000.xxxx, and stored into a variable...
_mkunit addRating (_mkratUx + (_mkratU / 2)) + 10;  -> Now, this actually confuses me too ;D but this was the only way I could add the rating to the unit, so that it includes the unitsRating.initialRating...

The other math bit just reverses that above action... Weirdly, but does it anyway...
I absolutely suck in maths so that's probably the reason why these are so confusing...
_ratUm = _ratUx - (_ratUx mod 1); -> this should 'even' up the rating (above the decimal of course) to make it 'zeroable'...
_ratU = ((_ratUx - _ratUm) * 10000) + random 3; -> the above decimal value is first 'zeroed' and then divided by 10000 to get the below decimal value... It can be done this way as OFP can understand only the above decimal value... the random 3 adds a random value at the end to compensate that 'OFP oddity on long floating points' stuff...
_ratU = _ratU * 2; -> well, this shows that there's something wrong in some of the above 'maths' as the gained value needs to be multiplied by two in order for it to be correct...
Altough, this was not needed when I was first testing this, I needed to add this later on, about the same time I started the vehicle testing...
Because at one point I could retrieve the drivers rating, but below decimal rating was always half of the actual rating, so I just added that line there...
If there's somebody who has a better way of completing this, please share...

So maybe when the unit gains more score, then things start getting screwed up

May be, altough There was no problems with the score gained, but then again, I never tested it so that it would have gone over 10000...

But, I think OFP works so that you can have 6 digits above the decimal and 6 below, so this should stay pretty stable if thinking like that...

Just a possibility, I guess. But perhaps it would help to do this:
  Private -> rating + 0.1
  Corporal -> rating + 0.2
  Sergeant -> rating + 0.3
And so on and so forth.  That way there are less numbers after the decimal to get messed up with OFP's 'fuzzy math'.

Could be, altough I would still need some of the fuzzy stuff to actually put that below the decimal ;D

That's why I never even place manned vehicles anymore (just an empty one and then moveindriver someone)

I do this too quite a lot, only when I'm sure I will not be scripting the vehicle into anything, I place the 'original' filled unit...
But usually I manage to funk up the mission when every single object on the map is somehow scripted

But I have some thoughts.... basically, you shouldn't use the "driver" command for vehicles, because some vehicles have no driver (eg, m2 machine guns). I think the "crew" command would be better

Trust me, I have tried crew too, in many many many (*commandant Lazard voice*) different ways...
The driver is currently there just to keep the stuff working on men so I can prove it works on some level...

just make it do the "rank" routine if a unit has been passed, otherwise it does the "mark" routine. For example

Yeah, good point... I'll add that...

Altough, this is just a 'rough' code, I usually start the optimizing when the code works otherwise...

First off, it appears to do the "rank" routine even when you call the script for the "mark" routine

This code is actually a bit earlier version that I currently had, but the current had so much 'confusement' in it that it just didn't work, so I reverted back to a version that works which of course has less stuff in it than the one that stopped working altogether...
This version indeed runs both the routines but will not when I get the vehicle part working...

[Unnamed]

Hi,

To test for vehicles just use:

Code: [Select]

If ((Vehicle Player)!=Player) Then {Hint Format ["Player is in a %1",Typeof (vehicle Player)]}

_ratU = _ratU * 2; -> well, this shows that there's something wrong in some of the above 'maths' as the gained value needs to be multiplied by two in order for it to be correct...

Is'nt all that to compensate for ratings less then 0? I think rating becomes negative when you team kill or something.

But as long as it works and the original rating is stored back in OFP, then I would not worry about

[h-]

To test for vehicles just use:

;D
I know that...

But in this case it won't help because this needs to work on AI too...
And as the thisList from a trigger won't differentiate vehicles from men (a vehicle is single unit (and a group of 1-3)... A man is single unit (and a group of 1)...) so vehicle _unit != _unit won't work...

I have also tried various methods of "vehicleType" countType [_unit] > 0...

Is'nt all that to compensate for ratings less then 0? I think rating becomes negative when you team kill or something.

Yeah, and if it goes down to -2000 or less, you are a 'renegade'...

But as long as it works and the original rating is stored back in OFP, then I would not worry about

Quite

@GB:

the idea of "storing" that rank in the unit's rating is very clever indeed

Quite, but as I say in the function comments (or do I?) this is not my idea, somebody posted about how OFP only reads the above decimal stuff from the rating a long time ago here at OFPEC...

The downside in this is that if someone uses this same method on something else, this and the other script(s) get screwed up...

[Unnamed]

And as the thisList from a trigger won't differentiate vehicles from men

I see, ThisList should just return pointers to objects. The problem is, you dont know the pointer of the driver, to make the comparison.

But if I understand it properly, you can do it this way:

Code: [Select]

(vehicle ((Crew s1) Select 0))!=((Crew s1) Select 0)
That will return true if it's a manned AI vehicle or false if it's just an AI soldier. You can test to see if it's an empty vehicle using IsNull. The crew command always returns an array of AI men, even if it's used on a soldier.

I guess a soldier's body is just considered a vehicle for the AI. Which is quite philosophical, for a computer game.

[h-]

I see, ThisList should just return pointers to objects

Quite, I was not sure if should use a 'real coding' terms, such as pointer...

The problem is, you dont know the pointer of the driver, to make the comparison.

It would need a pointer into a pointer

But if I understand it properly, you can do it this way

Hmm...
Will test that...

Makes me wonder why oh why I always seem to miss the obvious...
But with my luck, even that does not work...

I guess a soldier's body is just considered a vehicle for the AI.

Which is true, as all soldiers lye in the class CfgVehicles...
It's just the simulations that make the difference...

Which is quite philosophical, for a computer game.

;D ;D
Indeed...
So, to keep this philosophical there's always the old saying:
'It's not the class, it's the simulation that counts'...

[h-]

_array = _this select 0
if (count _this > 1) then {_unit = _this select 1; do rank routine}
else {do mark routine}

Ok, how exactly is this supposed to work???

I tried this, and if there's no element in the calling array ([array] call getRank) the _this select 1 returns the "scalar bool...."

So, I then made a sentence if (_this select 1 == "scalar bool....") then {do mark stuff} else {do rank stuff}
The mark stuff won't run at all ( ) which is totally weird, and then when the _this select 1 has a value ([array,unit] call getRank) the if (_unit == "scalar bool....") then .... gives a error message, and the |#| is situated after the then operator, so it suggests it's the 'General error in expression'...
And of course the rank then returns the "scalar bool....."...

So then used [array,""] call getRank, and made if (_this select 1 == ""} then {....}....
With exactly the same results, only now the "mark" stuff runs...
But still when using a unit instead of "" the if {_this select 1 == "") then {...} gives that same error message as above and of course the "rank" part won't run...

I have never used if/then/else in OFP succesfully, so I try to avoid it to the last breath...
For me the else{} only works if it has only one or two arguments in it, the other usually being exit (in .sqs of course...)

Here's the code now, but it will be changing...:

Code: [Select]

private ["_all","_unit","_mkunit","_mk_ratU","_mkratUx","_rank","_ratU","_ratUx","_ratUm"];
_all    = _this select 0;
_unit    = _this select 1;

if (_unit == "") then
{
     _cnt      = count _all;
     _mkratU   = 0;
     _mkratUx  = 0;
     _i        = 0;

     while "_i <= _cnt"
       do
        {
     _mkunit = _all select _i;
     _mkratUx = rating _mkunit;
   
     _mkunit addRating _mkratUx - (_mkratUx * 2);
     _mkratU = _mkratUx / 10000;
     _mkunit addRating (_mkratUx + (_mkratU / 2)) + 10;

     _i = _i + 1;
    };
}
else
{
   _ratUx = rating _unit;
    if (_ratUx < 0 && _ratUx > -2000)
        then
       {
        _ratUx = abs _ratUx;
       };
      _ratUm = _ratUx - (_ratUx mod 1);
      _ratU = ((_ratUx - _ratUm) * 10000) + random 3;
      _ratU = _ratU * 2;

   if (_ratU >= 7500)
    then {_rank = "COLONEL";};

   if (_ratU >= 5000 && _ratU < 7500)
    then {_rank = "MAJOR";};

   if (_ratU >= 3500 && _ratU < 5000)
    then {_rank = "CAPTAIN";};

   if (_ratU >= 2500 && _ratU < 3500)
    then {_rank = "LIEUTNANT";};

   if (_ratU >= 1500 && _ratU < 2500)
    then {_rank = "SERGEANT";};

   if (_ratU >= 500 && _ratU < 1500)
    then {_rank = "CORPORAL";};

   if ((_ratU >= 0 && _ratU < 500))
    then {_rank = "PRIVATE";};

   if (!(_unit in _all))
    then
       {
        hint format ["ERROR!!\n%1 not in the given array!",_unit];
        _rank = "<null>";
       };
   if ((rating _unit) <= -2000 && alive _unit)
    then {_rank = "RENEGADE TREASENOUS BASTARD!!!!";};
    };

_rank


[Unnamed]

I have never used if/then/else in OFP succesfully, so I try to avoid it to the last breath...
For me the else{} only works if it has only one or two arguments in it, the other usually being exit  (in .sqs of course...)

If you initalize _unit in {}'s. It wont be available to the rest of the script. Try this:

Code: [Select]

_unit=ObjNull
if (count _this > 1) then {_unit = _this select 1; do rank routine}
I prefer if then's, but probably easier done with:

Code: [Select]

? (count _this > 1) : _unit = _this select 1
P.S Same with exit, it would just exit the code contained in the {}.

[h-]

If you initalize _unit in {}'s. It wont be available to the rest of the script.

Right, absolutely totally forgot about that...

But, if you take a look at the quoted code, the _unit is initialized outside the first {}...

Same with exit, it would just exit the code contained in the {}

Oh??
Well, in sqf however exit does absolutely nothing...
No matter where you put it...

[Unnamed]

But, if you take a look at the quoted code, the _unit is initialized outside the first {}...

Yeah, I just commented on the smaller code section you quoted as I had the same problem not so long back. Took me ages to work out why

I see you do a check for _unit=="", does _unit become an empty string because of the call to private? Never thought to check if private actually initalises a variable. Or are you just passing in an emptry string by default?

Well, in sqf however exit does absolutely nothing...
No matter where you put it...

Yep, just tried a quick test. Never mind, cant say I ever used it in a function.

[h-]

I see you do a check for _unit=="", does _unit become an empty string because of the call to private?

No, it's defined as empty string when calling the function for the "mark" routine...
That's just to test whether the "scalar bool...." was the problem...

_unit is "scalar bool..." if it's not given a 'value' when calling the function...

I have to say I've made no progress...

I'm beginning to lean towards breaking the function into parts to see if that helps...

DISREGARD AS RETARDED...
UPDATE:
@GB:
Nope, I just can't get that stuff you suggested to work...

If no unit is passed, or it's substituted with some empty string or so, I get an error when ever a unit is passed...
And furthermore, the mark routine won't run...
And the error is the 'Generic error in expression'...

How on earth can this give the 'Generic...'
if (__unit == "")  then {call loadFile "fu.sqf"}    else {_rank = call loadFile "fu2.sqf"};
And the _unit is defined outside the {}...

I think this is actually the reason why I used that horrid "task"/nil stuff (it's been so long time since I started this I just can't remember all the details anymore...) so it seems I need to revert back to using it, because at least with it this function worked ....

[h-]

Still @GB:
Ehm... :-X
I got that suggestion of yours working and feel such a ****ing dum **********er right now...

One shouldn't be coding gazillion things at the same time, makes the brain retarded after a while...

[h-]

Ok, the vehicle check of your Unnamed works just fine, thnx!

But, now for more troubles...
The code works quite good now, men and other vehicles do return their correct ranks.

However, if used with forEach on a vehicle the 'scalar bool array...' is returned ("[array,_x] call getRank" forEach units group vehicleName)...
Or, if trying to get the rank of a certain individual who is in a vehicle (driver, gunner, commander, cargo) the same 'scalar bool array...' is returned...
Now, this is most likely due to the fact that I have removed all the error checks from the code, but this also means that the code won't work in these situations...
When using a sqs loop (the usual _unit = _list select _i stuff...) the code returns the ranks correctly on an array of men, but not if the array contains men from within a vehicle... In that case the ranks are completely wacked... Only the drivers rank is usually at least close to the real rank...

Hopefully somebody has some suggestions, I'm running out of ideas :-\...

Oh, and here's the current code. The usage is the same as before, but now the 'mark' routine is called with [array] call getRank, and the rank then retrieved with [array,unit] call getRank...:

Code: [Select]

private ["_all","_unit","_task","_mkunit","_mkvunit","_mk_ratU","_mkratUx","_rank","_ratU","_ratUx","_ratUm","_i","_iv"];
_all    = _this select 0;
_unit    = _this select 1;

if (count _this == 1)
 then
    {
     _cnt    = count _all;
     _mkratU   = 0;
     _mkratUx  = 0;
     _i        = 0;

     while "_i < _cnt"
       do
        {
         _mkunit = _all select _i;
         if ((vehicle ((crew _mkunit) select 0)) != ((crew _mkunit) select 0))
          then
             {
          _iv       = 0;
              while "_iv < (count (crew _mkunit))"
                do
                 {
          _mkvunit = ((crew _mkunit) select _iv);
          _mkratUx = rating _mkvunit;
              _mkvunit addRating _mkratUx - (_mkratUx * 2);
                  _mkratU = _mkratUx / 10000;
              _mkvunit addRating (_mkratUx + (_mkratU / 2)) + 10;

          _iv = _iv + 1;
         };
             };
         _mkratUx = rating _mkunit;

     _mkunit addRating _mkratUx - (_mkratUx * 2);
         _mkratU = _mkratUx / 10000;
     _mkunit addRating (_mkratUx + (_mkratU / 2)) + 10;

     _i = _i + 1;
       };
  }
  else
     {
      _ratUx = rating _unit;
      if ((vehicle ((crew _unit) select 0)) != ((crew _unit) select 0))
       then
          {
       _ratUx = rating ((crew _unit) select 0);
      };
    if (_ratUx < 0 && _ratUx > -2000)
        then
       {
        _ratUx = abs _ratUx;
       };
      _ratUm = _ratUx - (_ratUx mod 1);
      _ratU = ((_ratUx - _ratUm) * 10000) + random 3;
      _ratU = _ratU * 2;

     if ((vehicle ((crew _unit) select 0)) != ((crew _unit) select 0) && (((crew _unit) select 0) == gunner _unit || ((crew _unit) select 0) == commander _unit))
       then {_ratU = _ratU - 1000};

   if (_ratU >= 7500)
    then {_rank = "COLONEL";};

   if (_ratU >= 5000 && _ratU < 7500)
    then {_rank = "MAJOR";};

   if (_ratU >= 3500 && _ratU < 5000)
    then {_rank = "CAPTAIN";};

   if (_ratU >= 2500 && _ratU < 3500)
    then {_rank = "LIEUTNANT";};

   if (_ratU >= 1500 && _ratU < 2500)
    then {_rank = "SERGEANT";};

   if (_ratU >= 500 && _ratU < 1500)
    then {_rank = "CORPORAL";};

   if ((_ratU >= 0 && _ratU < 500))
    then {_rank = "PRIVATE";};

   if ((rating _unit) <= -2000 && alive _unit)
    then {_rank = "RENEGADE TREASENOUS BASTARD!!!!";};
     };

_rank
The code is also attached (rename..)... And has that more deatiled usage info...